[WIP] [CI:DOCS] GHA: Add staticcheck workflow #4892
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cevich
force-pushed
the
add_staticcheck
branch
9 times, most recently
from
9d17eea
to
f9dbe0c
Compare
Ref: * containers#4880 * containers#4884 This is ***NOT*** the same thing as the golangci-lint staticcheck. It checks other items not covered by golangci-lint, such as multiple (redundant) package imports). Signed-off-by: Chris Evich <cevich@redhat.com>
|
Ugh 😞 the staticcheck tool likely needs to run under Cirrus-CI in one/more of our managed CI VM images. Apparently it needs to build the project, which requires a special environment. I'm loath to manage/maintain multiple CI environments, and what we have running in Cirrus-CI is even more battle-hardened that github-actions. |
edsantiago
changed the title
|
More reason to not do this in CI: https://staticcheck.dev/docs/running-staticcheck/cli/build-tags/ I'll likely still bring the tool into the CI VM images, on the off-chance somebody wants to use it from the CI container images, or |
|
I would suggest not bringing it into the CI VM images. Instead, if someone needs it, they can vendor it into |
|
K. Thanks for the suggestion. |
What type of PR is this?
/kind other
What this PR does / why we need it:
Ref:
This is NOT the same thing as the golangci-lint staticcheck. It checks other items not covered by golangci-lint, such as multiple (redundant) package imports).
How to verify it
The new github-actions workflow will pass.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?